feat(wallet): add recent recipients tab #19942
Merged
+47
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (32)
|
J-Son89
commented
May 8, 2024
| @@ -33,7 +33,7 @@ | |||
| [options-drawer/view | |||
| {:name (:name collectible-details) | |||
| :image (:uri preview-url)}])}]))}] | |||
| :activity [activity/view {:activities []}] | |||
J-Son89
commented
May 8, 2024
| @@ -58,9 +58,6 @@ | |||
| :default-active @selected-tab | |||
| :data (tabs-data watch-only?) | |||
| :on-change (rn/use-callback (fn [tab] | |||
| (when (and (= :activity tab) | |||
There was a problem hiding this comment.
moved to account page transition
J-Son89
commented
May 8, 2024
| @@ -4,8 +4,6 @@ | |||
| [status-im.common.resources :as status.resources] | |||
| [utils.i18n :as i18n])) | |||
|
|
|||
| (def address "0x39cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd4") | |||
J-Son89
commented
May 8, 2024
| @@ -30,7 +30,8 @@ | |||
| (rf/reg-event-fx :wallet/navigate-to-account | |||
| (fn [{:keys [db]} [address]] | |||
| {:db (assoc-in db [:wallet :current-viewing-account-address] address) | |||
| :fx [[:dispatch [:navigate-to :screen/wallet.accounts address]]]})) | |||
| :fx [[:dispatch [:navigate-to :screen/wallet.accounts address]] | |||
| [:dispatch [:wallet/fetch-activities]]]})) | |||
J-Son89
commented
May 8, 2024
| :container-style style/empty-container-style}] | ||
| (into [rn/view {:style style/my-accounts-container}] | ||
| (map (fn [address] | ||
| [quo/address |
There was a problem hiding this comment.
eventually this will use accounts and saved address etc too 👍
J-Son89
commented
May 8, 2024
src/status_im/feature_flags.cljs
Outdated
| @@ -11,7 +11,7 @@ | |||
| (defonce ^:private feature-flags-config | |||
| (reagent/atom | |||
| {::community.edit-account-selection (enabled-in-env? :FLAG_EDIT_ACCOUNT_SELECTION_ENABLED) | |||
| ::wallet.activities (enabled-in-env? :FLAG_WALLET_ACTIVITY_ENABLED) | |||
| ::wallet.activities true | |||
There was a problem hiding this comment.
will revert/ remove this FF as it is not needed since updates in another pr:
#19906
J-Son89
requested review from
ulisesmac,
OmarBasem,
vkjr,
BalogunofAfrica,
mmilad75,
FFFra and
briansztamfater
J-Son89
force-pushed
the
jc/recent-transactions
branch
from
d13af5b
to
3ac1e7a
Compare
OmarBasem
approved these changes
May 9, 2024
| (defn- recent-transactions | ||
| [theme] | ||
| (let [recent-recipients (rf/sub [:wallet/recent-recipients])] | ||
| (if (zero? (count recent-recipients)) |
There was a problem hiding this comment.
Could be (empty? recent-recipients) ?
There was a problem hiding this comment.
thanks for the suggestion, will update this.
J-Son89
force-pushed
the
jc/recent-transactions
branch
2 times, most recently
from
d14b522
to
03388f6
Compare
56% of end-end tests have passedFailed tests (21)Click to expandClass TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (29)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
|
VolodLytvynenko
force-pushed
the
jc/recent-transactions
branch
from
531dc5c
to
61c094d
Compare
87% of end-end tests have passedFailed tests (5)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Hi @J-Son89 thank you for PR. One question Should the address be saved in the "Recent" tab if the user changes the network? Currently, it's not saved. Steps:
Actual result:The "Recent" tab is empty when the network is switched. If this is ok, then PR can be merged, no issues from my side |
@stefandunca - can you let me know how Desktop handled this |
AFAIK, we don't do anything special. We just call the get activity API for the current chains which will retrieve only activity filtered for that chain. Therefore, we filter out activity that is not done in the current mode which is ok. I can look into the code in detail, if you want, but I think we should not optimize yet for test networks mode, that is for developers mainly. |
J-Son89
force-pushed
the
jc/recent-transactions
branch
from
2fca855
to
e82c613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16991
This pr fetches the data for a user to send to a user they have recently sent to.
Note:
This pr is only version 1 in what is needed for this feature as in the design there is multiple versions of types of "recent" senders, i.e it can be an account, saved address or a contact.
The reason being is that the data from activities currently is not handling that information but there is a new backend end point we can update to which will get us this info moving forward.
Screen.Recording.2024-05-08.at.12.45.35.mov
Testing notes:
Go to account page,
Hit Send button
select recent tab(default)
select an address and ensure it gets sent to them
Note:
This pr does not add a new address when you send a transaction, to keep this pr smaller I will add this in a follow up pr.
For that reason feel free to feature test this pr in one go in that pr:
#19984