New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#19917] feat: rename keypair from wallet settings #19939
Conversation
Jenkins BuildsClick to see older builds (39)
|
6fb3e9e
to
ec3d228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
src/status_im/contexts/settings/wallet/keypairs_and_accounts/rename/view.cljs
Outdated
Show resolved
Hide resolved
ec3d228
to
5ad8263
Compare
81% of end-end tests have passed
Failed tests (8)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (42)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff ✅
Hi @mohsen-ghafouri ! I am wondering should this PR skip manual testing as you wrote steps to test. I've checked failed e2e and they are not related to your PR. |
Hi @mariia-skrypnyk this screen is behind the Feature flag and i think we agreed to ask for manual test on feature flag removal pull request. but if you want to do manual test now it's ready as well. CC @churik |
Thanks @mohsen-ghafouri! You can merge 🚀! |
2ed6a3b
to
91b1078
Compare
91b1078
to
3a114a9
Compare
fixes #19917
Summary
Implement the edit feature for key-pair names inside wallet settings.
Areas that maybe impacted
Steps to test
Result
Simulator.Screen.Recording.-.iPhone.13.-.2024-05-09.at.12.54.36.mp4
status: ready