fix_:sync contact request decision #19938
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
qfrank
force-pushed
the
fix/sync_contact_request_decision
branch
2 times, most recently
from
128a41e
to
430ee6f
Compare
siddarthkay
approved these changes
May 9, 2024
ilmotta
approved these changes
May 9, 2024
qfrank
force-pushed
the
fix/sync_contact_request_decision
branch
from
430ee6f
to
803adc3
Compare
|
Hi @VolodLytvynenko , this PR is ready for manual QA |
77% of end-end tests have passedFailed tests (10)Click to expandClass TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (40)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
|
40% of end-end tests have passedFailed tests (6)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Passed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
|
|
Hi @qfrank thank you for PR. No issues from my side. PR is ready to be merged |
17% of end-end tests have passedFailed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Passed tests (1)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
|
qfrank
force-pushed
the
fix/sync_contact_request_decision
branch
from
803adc3
to
43d7776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19455
after the fix, the result will looks like as screenshot shows
15 Pro is device A and 15 Pro Max is device B in this screenshot.
you can see that there're still differences between A and B after local pair sync.
syncContactRequestForInstallationContact,syncContactRequestForInstallationContactwill generate AC notification withdefaultContactRequestTexthowever, as @cammellos said:
as long as the message is the same (i.e accepted on both, declined on both), that's perfectly fine, I think the result is acceptable now.relate status-go PR
Platforms
status: ready