Fix schema error after logout #19933
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmotta
requested review from
flexsurfer,
yqrashawn,
smohamedjavid,
clauxx and
J-Son89
Jenkins Builds
|
flexsurfer
approved these changes
May 8, 2024
88% of end-end tests have passedFailed tests (5)Click to expandClass TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
|
ibrkhalil
approved these changes
May 8, 2024
J-Son89
approved these changes
May 8, 2024
clauxx
approved these changes
May 8, 2024
|
Hi @ilmotta ! Thanks for your fix 🙌 |
Hi there @mariia-skrypnyk 😊 I wasn't sure about that, so thanks for letting me know. |
seanstrom
approved these changes
May 8, 2024
|
Hi @ilmotta ! Thanks for spending your time and effort on such an errors 🙏 |
ilmotta
force-pushed
the
ilmotta/fix-schema-error-on-logout
branch
from
fe65cb3
to
d32ad37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a schema error after logout.
Interesting explanation...
The schema failure is due to
utils.image-server/get-initials-avatar-uribeing called with a nil profile customization color right after the user confirms logout. My first instinct was to just wrap the schema field with a:maybeschema and call it a day. But under the hood, the profile customization color really shouldn't be nil, so what is going on? Malli detected a potential issue.Right after logging out, the subscription
:profile/profile-with-imageis recomputed. I tried to find out what's causing that recomputation, but I timeboxed and gave up. One of its signal inputs is:profile/profile. Right after logout, the output of sub:profile/profileis always nil (this is correct, nobody is logged in). This means that the sub:profile/profile-with-imagewill try to calculate the multiaccount URI by passing a nil profile. This is wasteful computation and is also the cause of the schema forutils.image-server/get-initials-avatar-urito fail, because it expects the profile'scustomization-colorto be present.Areas that may be impacted
Anything displaying a profile image.
Steps to test
I truly expect no impact in profile images in general because the subscription
:profile/profileis only nil on logout, which is what this PR deals with. In any case, I smoke tested the app, changed profile images, etc, all good.I'll request manual QA after PR approval.
status: ready