Upgrade re-frame to latest #19931
Merged
Upgrade re-frame to latest #19931
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmotta
requested review from
cammellos,
shivekkhurana,
seanstrom,
vkjr,
flexsurfer,
yqrashawn,
clauxx and
ulisesmac
Jenkins BuildsClick to see older builds (20)
|
J-Son89
approved these changes
May 8, 2024
Parveshdhull
approved these changes
May 8, 2024
clauxx
approved these changes
May 8, 2024
jakubgs
approved these changes
May 9, 2024
ilmotta
force-pushed
the
ilmotta/upgrade-re-frame
branch
from
c1285fa
to
c756b4c
Compare
|
Hi @ilmotta ! Thanks for your PR! |
No @mariia-skrypnyk, it should be QAed if possible. This library is a fundamental part of our app. We shouldn't see any impact. I did my fair share of double-checks in this PR, but you'd be able to do a better job for sure. Edit: smoke tests should probably be enough. Upgrading re-frame always involves some kind of risk for us, and that's why I'm trying to do it now, because later on it will only get riskier as we approach deadlines. But seriously, the risk of bugs is very low, but we never know right? |
83% of end-end tests have passedFailed tests (7)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
|
ilmotta
force-pushed
the
ilmotta/upgrade-re-frame
branch
from
c756b4c
to
857bec6
Compare
yqrashawn
approved these changes
May 10, 2024
|
@ilmotta sure! Your PR will be QAed if needed. |
shivekkhurana
approved these changes
May 13, 2024
mariia-skrypnyk
force-pushed
the
ilmotta/upgrade-re-frame
branch
from
857bec6
to
f9dd614
Compare
ilmotta
force-pushed
the
ilmotta/upgrade-re-frame
branch
from
f9dd614
to
0eb80e0
Compare
85% of end-end tests have passedFailed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (44)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
Hi @ilmotta ! Smoke test done, all looks good on both platforms👌! Failed e2e are not related and you can merge your changes 🙌! |
Thank you @mariia-skrypnyk. Will merge later today. Next time I'll remember to add the label correctly :) |
ilmotta
force-pushed
the
ilmotta/upgrade-re-frame
branch
from
0eb80e0
to
42009a8
Compare
ilmotta
force-pushed
the
ilmotta/upgrade-re-frame
branch
from
42009a8
to
7e8d915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A quick win for us. Upgrade re-frame to latest, from
v1.3.0(released on 2022-08-27) to latestv1.4.3(released on 2024-01-25).Nothing outstanding, but this upgrade might entice your curiosity for the following reasons:
re-frame.alphanamespace, for testing proposed features (see flows and polymorphic subscriptions). If you haven't read before, you've been warned, these links can be a rabbit hole.dispatch-syncnow emits a:synctrace to indicate when it has finished. @flexsurfer you might care about this for re-frisk.v1.2.0.v1.4.0, but they don't affect us because we don't use interceptorspathandunwrap.Note
With the introduction of
re-frame.alpha, it is my expectation that, by upgrading re-frame, we make it easier for core devs to experiment with new ideas to solve old problems 😈Areas that may be impacted
Nothing in theory.
Steps to test
I ran smoke tests and the app is behaving the same, no warnings, which is to be expected, given the few breaking changes reported in re-frame's changelog don't affect us.
status: ready