Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Upgrade Clojure linter to latest version #19930

Merged
merged 1 commit into from May 9, 2024
Merged

DX: Upgrade Clojure linter to latest version #19930

merged 1 commit into from May 9, 2024
+129 −103

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented May 7, 2024

Summary

This PR upgrades clj-kondo (our Clojure linter) from v2023-09-07 to v2024-03-13, so ~6 months of development updates.

You can check out the changes starting at https://github.com/clj-kondo/clj-kondo/blob/master/CHANGELOG.md#20231020. Nothing terribly useful to us this time, but as usual, clj-kondo can catch more problems and more reliably than before.

Areas that may be impacted

None.

status: ready

@ilmotta ilmotta self-assigned this May 7, 2024
@ilmotta ilmotta requested a review from jakubgs as a code owner May 7, 2024 18:35
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 7, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 7, 2024 •
edited

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5bbf3e0 #1 2024-05-07 18:39:37 ~4 min tests 📄log
✔️ 5bbf3e0 #1 2024-05-07 18:41:32 ~6 min android-e2e 🤖apk 📲
✔️ 5bbf3e0 #1 2024-05-07 18:43:03 ~7 min android 🤖apk 📲
✔️ 5bbf3e0 #1 2024-05-07 18:44:15 ~8 min ios 📱ipa 📲
✔️ f200f24 #2 2024-05-09 11:35:30 ~4 min tests 📄log
✔️ f200f24 #2 2024-05-09 11:38:35 ~7 min android 🤖apk 📲
✔️ f200f24 #2 2024-05-09 11:38:43 ~8 min android-e2e 🤖apk 📲
✔️ f200f24 #2 2024-05-09 11:40:09 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 118bc8f #3 2024-05-09 12:51:43 ~5 min tests 📄log
✔️ 118bc8f #3 2024-05-09 12:53:25 ~6 min android 🤖apk 📲
✔️ 118bc8f #3 2024-05-09 12:53:57 ~7 min android-e2e 🤖apk 📲
✔️ 118bc8f #3 2024-05-09 12:58:39 ~12 min ios 📱ipa 📲
✔️ 4169c23 #4 2024-05-09 14:21:14 ~4 min tests 📄log
✔️ 4169c23 #4 2024-05-09 14:24:49 ~7 min android-e2e 🤖apk 📲
✔️ 4169c23 #4 2024-05-09 14:24:51 ~8 min android 🤖apk 📲
✔️ 4169c23 #4 2024-05-09 14:25:47 ~8 min ios 📱ipa 📲

@ilmotta ilmotta force-pushed the ilmotta/upgrade-clj-kondo branch 2 times, most recently from f200f24 to 118bc8f Compare May 9, 2024 12:46
@ilmotta ilmotta moved this from REVIEW to E2E Tests in Pipeline for QA May 9, 2024
@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 52
Failed tests: 11
Expected to fail tests: 2
Passed tests: 39

IDs of failed tests: 727230,702782,704613,703086,702948,702894,704615,727229,702807,702775,703629 

IDs of expected to fail tests: 703495,703503

Failed tests (11)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until `Text` by `accessibility id`: `community-description-text` will be presented 

    critical/chats/test_public_chat_browsing.py:768: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find ProfileButton by accessibility id: open-profile
    Device 1: Find Button by accessibility id: icon, Messages, label-component, icon 

    critical/chats/test_public_chat_browsing.py:690: in test_community_contact_block_unblock_offline
    profile_1.profile_messages_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `icon, Messages, label-component, icon` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_community_edit_delete_message_when_offline, id: 704615

    # STEP: Receiver is checking if initial messages were delivered
    Device 1: Looking for a message by text: message to edit 

    critical/chats/test_public_chat_browsing.py:783: in test_community_edit_delete_message_when_offline
    self.channel_1.driver.fail("Message '%s' was not received" % message)
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Message 'message to edit' was not received



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'Where is a cat?' 

    critical/chats/test_public_chat_browsing.py:1051: in test_community_hashtag_links_to_community_channels
    self.channel_1.send_message(cats_message)
../views/chat_view.py:982: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; 
 RemoteDisconnected



    Device sessions

    2. test_community_join_when_node_owner_offline, id: 703629

    Device 1: Tap on found: Button
    Device 1: Find ChatButton by accessibility id: create-open-community 

    critical/chats/test_public_chat_browsing.py:1104: in test_community_join_when_node_owner_offline
    self.home_1.create_community(community_type="open")
../views/home_view.py:495: in create_community
    self.create_open_community_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: ChatButton by accessibility id: `create-open-community` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 2: Find OpenInStatusButton by xpath: //*[@text="Open in Status"]
    Device 2: Tap on found: OpenInStatusButton 

    critical/chats/test_1_1_public_chats.py:179: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message with emoji was not sent or received in 1-1 chat
E    No reply received in 1-1 chat



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:109: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:99: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:86: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:80: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Passed tests (39)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    @ilmotta ilmotta force-pushed the ilmotta/upgrade-clj-kondo branch from 118bc8f to 4169c23 Compare May 9, 2024 14:16
    @ilmotta ilmotta merged commit 52a6f5c into develop May 9, 2024
    6 checks passed
    Pipeline for QA automation moved this from E2E Tests to DONE May 9, 2024
    @ilmotta ilmotta deleted the ilmotta/upgrade-clj-kondo branch May 9, 2024 15:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jakubgs jakubgs jakubgs approved these changes

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @ilmotta ilmotta

    Labels
    E:Mobile Developer XP skip-manual-qa
    Projects
    Pipeline for QA
      
    DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    None yet
    4 participants
    @ilmotta @status-im-auto @jakubgs @mohsen-ghafouri