fix: entering two zeros in a row in the 'Amount' field in wallet #19911
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simple fix, I think can skip QA cc @J-Son89 |
Jenkins BuildsClick to see older builds (10)
|
J-Son89
reviewed
May 6, 2024
| @@ -78,9 +78,10 @@ | |||
|
|
|||
| (defn add-character | |||
| [state character] | |||
| (when (can-add-character? state character) | |||
| (if (can-add-character? state character) | |||
There was a problem hiding this comment.
is this all to handle the custom keyboard?
We should really raise this with the design team as something to reconsider as it seems to be a bug factory that we could easily avoid :)
There was a problem hiding this comment.
also this looks good but since this is in /common/ I wonder is this code used elsewhere and if so is this the expected behaviour for these uses?
There was a problem hiding this comment.
is this all to handle the custom keyboard?
@J-Son89 Yes 🤷♂️
We should really raise this with the design team as something to reconsider as it seems to be a bug factory
Agreed! I think @vkjr worked on this, maybe he can share his thoughts also (and maybe @ulisesmac)
also this looks good but since this is in /common/
It is used in the send screen only.
The fix here is to return the same state if the character cannot be added. Previously was returning nil hence the crash.
There was a problem hiding this comment.
yeah let's collate of all the lists and issues this brings in. I believe it's also a big takeaway from accessibility of the end user. @shivekkhurana was discussing something like this before.
J-Son89
approved these changes
May 8, 2024
|
Hi @OmarBasem ! I am moving back your PR to the corresponding column as it doesn't meet the requirements outlined here: Please, make sure your fix should/shouldn't be tested by QA's and add necessary information to PR's description. |
|
Thanks @mariia-skrypnyk, updated the description. |
Thanks @OmarBasem for adding label and description! 🙌🤗 |
|
Will review e2e and let you know! @OmarBasem |
83% of end-end tests have passedFailed tests (7)Click to expandClass TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Hey @mariia-skrypnyk, is this good to merge? |
|
Hey @OmarBasem ! Thanks for your patience! Just needed to manually check some moments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #19908
This PR fixes an issue that caused a crash when typing zeroes in the input amout on the send screen.
Skipping QA as it is a simple fix.
Demo:
Screen_Recording_20240506_162100_Status.mp4