Remove old status community from the database #19905
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrkhalil
approved these changes
May 5, 2024
Jenkins BuildsClick to see older builds (32)
|
shouldn't that depend if this version bump is also pulling in other changes within Status-Go? |
I think that the impact on status-mobile should be taken care of during review of the status-go PR. |
Parveshdhull
force-pushed
the
chore/remove-status-community
branch
from
e8037ec
to
c1f6ae2
Compare
Parveshdhull
force-pushed
the
chore/remove-status-community
branch
2 times, most recently
from
fb7187a
to
c35d870
Compare
81% of end-end tests have passedFailed tests (8)Click to expandClass TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (42)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
|
|
Hey @Parveshdhull! Thank you for the PR! Could you please rebase go and mobile branches? Thank you! |
Parveshdhull
force-pushed
the
chore/remove-status-community
branch
from
c35d870
to
f475e3a
Compare
83% of end-end tests have passedFailed tests (7)Click to expandClass TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
closing the PR as removal of status old community is breaking the status go tests and needs some workaround |
qfrank
force-pushed
the
chore/remove-status-community
branch
from
f475e3a
to
ed696f8
Compare
✔️ status-mobile/prs/android/PR-19905#1 🔹 ~7 min 41 sec 🔹 f475e3a 🔹 📦 android package |
|
reopen as removal of status old community is not breaking the status go tests anymore cc @Parveshdhull @pavloburykh |
88% of end-end tests have passedFailed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
|
thank you! Will take a look at it on Monday |
qfrank
force-pushed
the
chore/remove-status-community
branch
from
ed696f8
to
ba3a6ea
Compare
|
Hey @Parveshdhull! Thanx for the PR! Please, take a look at the issue. ISSUE 1 Old Status community is still shown within Opened tab for recovered userNOTE: ask me for the seed phrase of the user. Steps:
Actual result: Old Status community is displayed within Opened tab |
|
@Parveshdhull maybe I am missing something: where have we used to show this old community in mobile app? Is it only Opened tab or any other places? I want to make sure what exact places should I check. Also, maybe you have some other suggestions on what should be tested in this PR based on related go changes? |
qfrank
force-pushed
the
chore/remove-status-community
branch
from
ba3a6ea
to
440e488
Compare
Thank you very much @qfrank for working on the PR and @pavloburykh for testing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19868
depends on status-im/status-go#5114
status: ready