Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#19917] feat: rename keypair from wallet settings #19939

Merged
merged 4 commits into from May 13, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented May 8, 2024

fixes #19917

Summary

Implement the edit feature for key-pair names inside wallet settings.

Areas that maybe impacted

  • Rename keypair

Steps to test

  • Open Wallet setting
  • Click on not default keypair's action button
  • Click on rename

Result

Simulator.Screen.Recording.-.iPhone.13.-.2024-05-09.at.12.54.36.mp4

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this May 8, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 8, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 8, 2024

Jenkins Builds

Click to see older builds (39)
Commit #️⃣ Finished (UTC) Duration Platform Result
f064210 #1 2024-05-08 12:19:17 ~3 min tests 📄log
✔️ f064210 #1 2024-05-08 12:23:12 ~6 min android-e2e 🤖apk 📲
✔️ f064210 #1 2024-05-08 12:24:58 ~8 min android 🤖apk 📲
✔️ f064210 #1 2024-05-08 12:27:43 ~11 min ios 📱ipa 📲
✔️ afff226 #2 2024-05-08 13:32:28 ~4 min tests 📄log
✔️ afff226 #2 2024-05-08 13:35:53 ~7 min android-e2e 🤖apk 📲
✔️ afff226 #2 2024-05-08 13:36:18 ~8 min android 🤖apk 📲
✔️ afff226 #2 2024-05-08 13:37:09 ~9 min ios 📱ipa 📲
d04db52 #3 2024-05-09 08:20:36 ~2 min tests 📄log
✔️ d04db52 #3 2024-05-09 08:25:41 ~7 min android 🤖apk 📲
✔️ d04db52 #3 2024-05-09 08:25:42 ~7 min android-e2e 🤖apk 📲
✔️ d04db52 #3 2024-05-09 08:27:20 ~9 min ios 📱ipa 📲
1adf5a5 #4 2024-05-09 08:43:31 ~2 min tests 📄log
✔️ 1adf5a5 #4 2024-05-09 08:47:57 ~6 min android 🤖apk 📲
✔️ 1adf5a5 #4 2024-05-09 08:50:02 ~8 min ios 📱ipa 📲
✔️ 1adf5a5 #4 2024-05-09 08:51:45 ~10 min android-e2e 🤖apk 📲
bc3815d #5 2024-05-09 08:59:29 ~4 min tests 📄log
✔️ bc3815d #5 2024-05-09 09:01:19 ~6 min android-e2e 🤖apk 📲
✔️ bc3815d #5 2024-05-09 09:04:06 ~8 min ios 📱ipa 📲
✔️ bc3815d #5 2024-05-09 09:04:27 ~9 min android 🤖apk 📲
✔️ 1bc7e19 #6 2024-05-09 09:17:18 ~4 min tests 📄log
✔️ 1bc7e19 #6 2024-05-09 09:21:11 ~8 min android-e2e 🤖apk 📲
✔️ 1bc7e19 #6 2024-05-09 09:21:17 ~8 min android 🤖apk 📲
✔️ 1bc7e19 #6 2024-05-09 09:21:17 ~8 min ios 📱ipa 📲
✔️ 6fb3e9e #8 2024-05-10 13:40:50 ~4 min tests 📄log
✔️ 6fb3e9e #8 2024-05-10 13:42:41 ~5 min android 🤖apk 📲
✔️ 6fb3e9e #8 2024-05-10 13:46:03 ~9 min ios 📱ipa 📲
✔️ 6fb3e9e #8 2024-05-10 13:46:48 ~10 min android-e2e 🤖apk 📲
✔️ ec3d228 #9 2024-05-10 14:29:10 ~4 min tests 📄log
✔️ ec3d228 #9 2024-05-10 14:32:53 ~8 min android-e2e 🤖apk 📲
✔️ ec3d228 #9 2024-05-10 14:32:59 ~8 min android 🤖apk 📲
✔️ ec3d228 #9 2024-05-10 14:33:26 ~8 min ios 📱ipa 📲
✔️ 5ad8263 #10 2024-05-13 07:48:49 ~5 min tests 📄log
✔️ 5ad8263 #10 2024-05-13 07:51:40 ~8 min android-e2e 🤖apk 📲
✔️ 5ad8263 #10 2024-05-13 07:51:44 ~8 min android 🤖apk 📲
✔️ 5ad8263 #10 2024-05-13 07:52:13 ~8 min ios 📱ipa 📲
✔️ ece5532 #11 2024-05-13 13:33:13 ~4 min tests 📄log
✔️ ece5532 #11 2024-05-13 13:37:15 ~8 min android-e2e 🤖apk 📲
✔️ ece5532 #11 2024-05-13 13:38:00 ~9 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 91b1078 #13 2024-05-13 13:49:28 ~3 min tests 📄log
✔️ 3a114a9 #14 2024-05-13 14:02:39 ~8 min android-e2e 🤖apk 📲
✔️ 3a114a9 #14 2024-05-13 14:02:45 ~8 min android 🤖apk 📲
✔️ 3a114a9 #14 2024-05-13 14:03:13 ~9 min tests 📄log
✔️ 3a114a9 #14 2024-05-13 14:06:02 ~11 min ios 📱ipa 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/key-pair-rename branch 8 times, most recently from 6fb3e9e to ec3d228 Compare May 10, 2024 14:24
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review May 10, 2024 14:24
Copy link
Contributor

@ibrkhalil ibrkhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@status-im-auto
Copy link
Member

81% of end-end tests have passed

Total executed tests: 52
Failed tests: 8
Expected to fail tests: 2
Passed tests: 42
IDs of failed tests: 727230,704613,702948,727229,702869,702807,727232,702775 
IDs of expected to fail tests: 703495,703503 

Failed tests (8)

Click to expand
  • Rerun failed tests

  • Class TestCommunityOneDeviceMerged:

    1. test_community_undo_delete_message, id: 702869

    Device 1: Tap on found: Button
    Device 1: Find `Button` by `xpath`: `//*[@text="Undo"]`

    critical/chats/test_public_chat_browsing.py:112: in test_community_undo_delete_message
        self.channel.element_by_text("Undo").click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//*[@text="Undo"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab

    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
        sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
    critical/test_wallet.py:39: in _get_balances_before_tx
        self.wallet_1.wallet_tab.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track']

    critical/test_wallet.py:109: in test_wallet_send_eth
        self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
    ../views/wallet_view.py:99: in send_asset
        self.confirm_transaction()
    ../views/wallet_view.py:86: in confirm_transaction
        self.slide_and_confirm_with_password()
    ../views/wallet_view.py:80: in slide_and_confirm_with_password
        self.slide_button_track.slide()
    ../views/base_view.py:257: in slide
        self.swipe_right_on_element(width_percentage=1.3, start_x=100)
    ../views/base_element.py:308: in swipe_right_on_element
        location, size = self.get_element_coordinates()
    ../views/base_element.py:294: in get_element_coordinates
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Find EditBox by accessibility id: add-address-to-watch
    Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox

    critical/test_wallet.py:190: in test_wallet_add_remove_watch_only_account
        self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
    ../views/wallet_view.py:120: in add_watch_only_account
        self.account_has_activity_label.wait_for_visibility_of_element()
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button

    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE
    



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab

    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE
    



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text

    critical/chats/test_public_chat_browsing.py:1092: in test_community_hashtag_links_to_community_channels
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Receiver was not navigated to the cats channel
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
        self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
    ../views/chat_view.py:225: in wait_for_status_to_be
        raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
     Message status was not changed to Delivered, it's Sent
    



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Chat is still muted after timeout 
    

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (42)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Copy link
    Member

    @seanstrom seanstrom left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice stuff ✅

    @mariia-skrypnyk
    Copy link

    Hi @mohsen-ghafouri !

    I am wondering should this PR skip manual testing as you wrote steps to test.
    Just want to be sure any mistake here.
    Thanks!

    I've checked failed e2e and they are not related to your PR.

    @mohsen-ghafouri
    Copy link
    Contributor Author

    Hi @mariia-skrypnyk this screen is behind the Feature flag and i think we agreed to ask for manual test on feature flag removal pull request. but if you want to do manual test now it's ready as well.

    CC @churik

    @mariia-skrypnyk
    Copy link

    Thanks @mohsen-ghafouri!
    You are wright.
    Great you put steps for future testing purposes.

    You can merge 🚀!

    @mohsen-ghafouri mohsen-ghafouri force-pushed the feat/key-pair-rename branch 2 times, most recently from 2ed6a3b to 91b1078 Compare May 13, 2024 13:45
    @mohsen-ghafouri mohsen-ghafouri merged commit 6be1adb into develop May 13, 2024
    6 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the feat/key-pair-rename branch May 13, 2024 14:07
    Pipeline for QA automation moved this from E2E Tests to DONE May 13, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Development

    Successfully merging this pull request may close these issues.

    Allow users to rename key-pair from wallet settings
    5 participants