feat_: light, no-network versions of permission checking functions #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
jrainville
reviewed
May 15, 2024
protocol/communities/manager.go
Outdated
Comment on lines
2957
to
2962
| viewSatisfied := false | ||
| if !hasViewOnlyPermissions { | ||
| viewSatisfied = true | ||
| } else { | ||
| viewSatisfied = (meAsMember != nil && meAsMember.GetChannelRole() == protobuf.CommunityMember_CHANNEL_ROLE_VIEWER) | ||
| } |
There was a problem hiding this comment.
Suggested change
| viewSatisfied := false | |
| if !hasViewOnlyPermissions { | |
| viewSatisfied = true | |
| } else { | |
| viewSatisfied = (meAsMember != nil && meAsMember.GetChannelRole() == protobuf.CommunityMember_CHANNEL_ROLE_VIEWER) | |
| } | |
| viewSatisfied := !hasViewOnlyPermissions || (meAsMember != nil && meAsMember.GetChannelRole() == protobuf.CommunityMember_CHANNEL_ROLE_VIEWER) |
protocol/communities/manager.go
Outdated
Comment on lines
2964
to
2969
| postSatisfied := false | ||
| if !hasViewAndPostPermissions { | ||
| postSatisfied = true | ||
| } else { | ||
| postSatisfied = (meAsMember != nil && meAsMember.GetChannelRole() == protobuf.CommunityMember_CHANNEL_ROLE_POSTER) | ||
| } |
There was a problem hiding this comment.
Suggested change
| postSatisfied := false | |
| if !hasViewAndPostPermissions { | |
| postSatisfied = true | |
| } else { | |
| postSatisfied = (meAsMember != nil && meAsMember.GetChannelRole() == protobuf.CommunityMember_CHANNEL_ROLE_POSTER) | |
| } | |
| postSatisfied := !hasViewAndPostPermissions || (meAsMember != nil && meAsMember.GetChannelRole() == protobuf.CommunityMember_CHANNEL_ROLE_POSTER) |
MishkaRogachev
approved these changes
May 16, 2024
endulab
force-pushed
the
14220-check-permissions-light-mode
branch
from
8dd311d
to
faa06a3
Compare
jrainville
approved these changes
May 16, 2024
mprakhov
reviewed
May 16, 2024
| @@ -3026,6 +3098,27 @@ func (m *Manager) CheckAllChannelsPermissions(communityID types.HexBytes, addres | |||
| return response, nil | |||
| } | |||
|
|
|||
| // Light version of CheckAllChannelsPermissionsLight, which does not use network requests. | |||
| // Instead of checking wallet balances it checks if there is an access to a member list of chats. | |||
| func (m *Manager) CheckAllChannelsPermissionsLight(communityID types.HexBytes) (*CheckAllChannelsPermissionsResponse, error) { | |||
There was a problem hiding this comment.
minor: maybe rename it CheckAllChannelsPermissionsOffline?
endulab
force-pushed
the
14220-check-permissions-light-mode
branch
from
faa06a3
to
3b0135b
Compare
Light functions are based on the fact that permissions are met if the user is on community/channel member list. If the user is not on the list, permissions will not be met and the client is responsible to use regular permissions-check functions. For all permissions-check functions, corresponding light versions are added: CheckAllChannelsPermissionsLight, CheckChannelPermissionsLight, CheckPermissionToJoinLight. Issue #14220
endulab
force-pushed
the
14220-check-permissions-light-mode
branch
from
3b0135b
to
d55e177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all permissions-check functions, corresponding light versions are added: CheckAllChannelsPermissionsLight, CheckChannelPermissionsLight, CheckPermissionToJoinLight (we can discuss naming convention).
Light functions are based on the fact that permissions are met if the user is on community/channel member list. If the user is not on the list, permissions will not be met and the client is responsible to use regular permissions-check functions.
Issue #14220