don't remove tagging characters when sanitizing metric names #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes are included as part of #697, so this PR will be a no-op once that one is merged. |
|
#697 has been merged so I'm closing this one off 🎊 thanks so much for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue referenced in #643 where tagged series names have the
;and=characters stripped off by the sanitization code.With this patch those characters are no longer stripped, allowing the use of tagged series.
There are a couple of issues with this approach which are that there is no handling for scenarios where suffixes are added to the series names, so the utility of supporting tags is limited to gauges without further changes.
The other issue is that anyone who is sending metrics today that include those characters will see their series names change as they will no longer be stripped.