Fix for Issue #412 [AMD official] #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #412
This install error is caused by a bug related to the warp size of Radeon GPUs in one of the ROCm libraries (rocprim). As a result, the warp size 32 based kernel launch fails to compile. In this fix, we use the same kernel parameters for both Instinct and Radeon GPUs. The performance hit is negligible.
The bug in rocmprim has been fixed (ROCm/rocPRIM#542) but is not in the release yet. We can open another PR to revert the code once this rocprim fix is in the release.