perf(scala): use scala-cli first to avoid timeout #5952
Merged
+86
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scala-cli
and fallback to current ( slower )scclac
utils.rs
mock commands to callscala-cli
and get back the current Scala version3.4.1
beforescalac
which returns... 2.13.5 ...
. Keep them distinct for clearer testing.Motivation and Context
Partial fix to #5583
scalac --version
has some noticeable ( most likely jvm ) startup time. Depending on the computer, this can cause a timeout.scala-cli version --scala
usually has little to no startup time since it is either compiled to a native binary or use its own embedded GraalVM. It also outputs exactly and only the version number which avoids some string parsing.This can only be considered a partial fix as
scala-cli
is not a hard requirement to work with Scala whereasscalac
is.Screenshots (if appropriate):
How Has This Been Tested?
Checklist: