Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable aarch64 msi building #5951

Merged
merged 1 commit into from May 12, 2024
Merged

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented Apr 30, 2024

Description

The Wix v3 version on the gh windows images has been updated at some point and now supports building aarch64-pc-windows-msvc MSI installer without needing to upgrade to wix v4/v5 (#5407).
I uncommented the special checks excluding aarch64-pc-windows-msvc and refactored the wingetcreate invocation to push all installers.

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna davidkna merged commit 84162dc into starship:master May 12, 2024
17 checks passed
@davidkna davidkna deleted the wix-aarch64-ci branch May 12, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants