Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AzureRm) Adds a basic Azure Powershell module. #5910

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

theonlyames
Copy link

@theonlyames theonlyames commented Apr 7, 2024

Description

Adds a alternative version of the Azure module for use with Azure PowerShell, as they store their context files separately using different formats. It still needs some tests to be written up for it.

Motivation and Context

I use both the Azure PowerShell module and Azure CLI for my work, and the existing Azure module only supports Azure CLI. Originally I wanted to augment the existing module, I decided to make it a separate module instead as the context file structure is more complicated than what AzureCLI uses.

Screenshots (if appropriate):

image

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@theonlyames theonlyames marked this pull request as ready for review April 10, 2024 14:30
@theonlyames
Copy link
Author

I am still writing tests for this, but am curious as to whether people think it is preferable to do this as a separate module or whether I should try to integrate the functionality directly in the azure module similar to how Oh My Posh does things with its Az module's source property.

Amelia Wheeler added 6 commits April 12, 2024 14:51
Removed Custom Deserializer for Subscription.
Fixed Null Subscription Case
- Improved get_azurerm_context_info function
@davidkna
Copy link
Member

I am still writing tests for this, but am curious as to whether people think it is preferable to do this as a separate module or whether I should try to integrate the functionality directly in the azure module similar to how Oh My Posh does things with its Az module's source property.

I think it might be a good idea to combine these, but I am not familiar with the distinction between the two clients.

@theonlyames
Copy link
Author

theonlyames commented Apr 30, 2024

I am still writing tests for this, but am curious as to whether people think it is preferable to do this as a separate module or whether I should try to integrate the functionality directly in the azure module similar to how Oh My Posh does things with its Az module's source property.

I think it might be a good idea to combine these, but I am not familiar with the distinction between the two clients.

I have a WIP branch for that, but I feel like it might complicate tests and limit potential configurations more than I'd prefer.

That being said, the tests for this are now complete and ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants