docs(nu): Simplify Nushell integration instructions #5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by jdx/mise-docs#46 for consistency between tools.
texastoland
force-pushed
the
nushell_simplify
branch
3 times, most recently
from
ade338e
to
bdfec33
Compare
texastoland
added a commit
to texastoland/mise-docs
that referenced
this pull request
Mar 17, 2024
Manually picked from starship/starship#5845.
texastoland
force-pushed
the
nushell_simplify
branch
2 times, most recently
from
90ebebb
to
8bcb200
Compare
Reinitializes the script at most once every day. This is necessary because doing so every
time could lead to thousands of concurrent writes calling `| par-each { nu -c }`.
texastoland
force-pushed
the
nushell_simplify
branch
from
8bcb200
to
d782659
Compare
texastoland
added a commit
to texastoland/mise-docs
that referenced
this pull request
Mar 17, 2024
Manually picked from starship/starship#5845.
texastoland
changed the title
andytom
changed the title
jdx
pushed a commit
to jdx/mise-docs
that referenced
this pull request
Mar 22, 2024
* Update Nushell integration Depends on jdx/mise#1763 in release. * Automate reinstallation Manually picked from starship/starship#5845.
amtoine
reviewed
Mar 23, 2024
Because it follows a convention of providing a command to run instead of code to add 🤓 Here's a deployed example. The currrent instructions presume the user is already familiar with the configuration docs. Starting Nu they can (I did months ago) run into issues like the files being located in an unexpected place on Mac or not having an editor configured for Starship in particular was the first thing I tried to integrate. This "just works" while providing enough context for expert users to customize as we please! |
texastoland
force-pushed
the
nushell_simplify
branch
from
54ada20
to
1d2f4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements @davidkna's astute feedback in #5844. Always runs unless non-interactive (a script). Clarifies and simplifies installation while reducing (possibly concurrent) file writes. RFC @amtoine (previous committer) @fdncred.