Add s390x arch build #5810
Open
Add s390x arch build #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested whether this compiles with |
lysliu
force-pushed
the
patch-1
branch
2 times, most recently
from
279eb93
to
38a14ad
Compare
davidkna
requested changes
Mar 21, 2024
rust using cross build tool so it can build out s390x binary from x86 platform fix: starship#5808
|
Again, please also change the installation script to pick |
|
@davidkna I think all the comments already addressed. |
|
There hasn't been a new push since my last comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust using cross build tool
so it can build out s390x binary from x86 platform
fix: #5808
Description
Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: