Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(preset): new preset "Pastel Rainbow" #5806

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ecspresso
Copy link

Description

Created a new preset named "Pastel Rainbow". It is the same as Gruvbox Rainbow but with the colors of Pastel Powerline.

Motivation and Context

Because I preferred the colors of Pastel Powerline but liked the formating of Gruvbox. I wanted to share my version.

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

ecspresso and others added 2 commits February 27, 2024 20:27
Added preset pastel-rainbow, same as gruvbox-rainbow but with pastel-powerline colors.
Same as Gruvbox but with the colors of Pastel Powerline.
@ecspresso
Copy link
Author

Please help me correct any errors. I could not find any other documentation for adding a new preset other than "edit this readme".

Removed offending comments
@andytom andytom changed the title docs new preset "Pastel Rainbow" docs(preset): new preset "Pastel Rainbow" Feb 28, 2024
@ecspresso
Copy link
Author

I can see that there is an error but I cannot tell what.

@jemhv
Copy link

jemhv commented Apr 7, 2024

I can see that there is an error but I cannot tell what.

well in the docs/presets/readme.md file you have two line gap before ## [Pastel Rainbow] (./pastel-rainbow.md), please remove one gap and you're good to go.

@ecspresso
Copy link
Author

Found one more lined that was causing an error, removed that too.

The last error seems to be my reference to gruvbox-rainbow.toml which is not in my PR but is the one I based it on.

Do I need to fix that?

@jemhv
Copy link

jemhv commented Apr 11, 2024

Why did you put your file in .vuepress? it should be in presets that's right in docs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the img and toml files inside the right directory, docs/public/presets/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths changed when we switched to vitepress.

@davidkna
Copy link
Member

Instead of a new theme, I would prefer adding a new palettes definition to Gruvbox Rainbow instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants