Allow user to set special colour for exit code 130 (ctrl-c) #5765
+106
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft as the tests are not currently passing, and I would like to solicit feedback on the general idea before putting energy into resolving the issues & cleaning up the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows the user to set a colour not only for exit code failure and success, but also exit code 130 (ctrl-c). This is set to yellow by default. This also fixes an issue where even the existing red for exit code failure was cleared by entering vim mode
Motivation and Context
I have been using this in a fork for a long time (see the master branch of the source fork of this PR if you really want) and i think others may desire this feature
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: