fix: always use compressed public keys in signer config #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstove
force-pushed
the
feat/fix-signer-pk-hex
branch
from
c9dd36b
to
5a905bc
Compare
hstove
changed the title
stacks-signer check-config
|
Fixes #4761 |
jferrant
previously approved these changes
May 9, 2024
hstove
force-pushed
the
feat/fix-signer-pk-hex
branch
from
5a905bc
to
c8bdbcf
Compare
|
Rebased and ready for review 👍🏼 |
jferrant
approved these changes
May 17, 2024
kantai
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signer converts its private key to a Stacks address when looking up whether it is registered in a reward cycle. If the configured private key didn't have a
compress_publicflag (ie ending in01), the public key wouldn't be compressed when generating the Stacks address. This could lead to the signer incorrectly thinking it isn't registered.This PR also updates the
check-configcommand to output the compressed public key.Relates to: