Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix bitcoin reorg flap test #4601

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from
Draft

Attempt to fix bitcoin reorg flap test #4601

wants to merge 5 commits into from

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Mar 28, 2024

Forcefully kill the bitcoind in case it fails to stop.

@obycode obycode changed the base branch from master to next March 28, 2024 02:21
@obycode
Copy link
Contributor Author

obycode commented Mar 28, 2024

It looks like some change in between the original fix to this problem and the current next has caused the test to fail, so that needs to get fixed. I'll look into it tomorrow.

@saralab saralab requested a review from wileyj April 1, 2024 15:06
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 77.34%. Comparing base (9708368) to head (a4b5295).
Report is 3 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4601      +/-   ##
==========================================
- Coverage   83.39%   77.34%   -6.05%     
==========================================
  Files         470      470              
  Lines      332704   332804     +100     
  Branches      317      317              
==========================================
- Hits       277442   257413   -20029     
- Misses      55254    75383   +20129     
  Partials        8        8              
Files Coverage Δ
testnet/stacks-node/src/tests/neon_integrations.rs 61.38% <0.00%> (-12.07%) ⬇️

... and 193 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9708368...a4b5295. Read the comment docs.

@wileyj
Copy link
Contributor

wileyj commented Apr 5, 2024

this PR still needs more work. brice and I have discussed some alternatives but it may not be ready for 2.5.

i would recommend we move this to draft/backlog for now

@obycode obycode marked this pull request as draft April 6, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants