Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks-explorer fails to compile #350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Nov 3, 2023

Summary of Changes

CI has been failing lately. These changes fixed it for me. I ported the changes from the Hiro dockerfile for stacks-explorer.

Evidence:
https://github.com/stacks-network/sbtc/actions/runs/6578085435/job/18167621690?pr=303

Testing

Risks

How were these changes tested?

Locally and in CI for open PRs.

What future testing should occur?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CAGS295 CAGS295 added bug Something isn't working devenv Development Environment labels Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6470223) 43.44% compared to head (24782a6) 43.44%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   43.44%   43.44%           
=======================================
  Files          45       45           
  Lines        5467     5467           
  Branches       47       47           
=======================================
  Hits         2375     2375           
  Misses       3091     3091           
  Partials        1        1           
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CAGS295 CAGS295 self-assigned this Nov 9, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@CAGS295
Copy link
Contributor Author

CAGS295 commented Nov 20, 2023

@AshtonStephens who else can review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devenv Development Environment
Projects
No open projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants