Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert namor upgrade #1084

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: revert namor upgrade #1084

merged 2 commits into from
Nov 28, 2023

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Nov 23, 2023

After #969 the UI was broken:

Screenshot 2023-11-23 at 15 39 56 Screenshot 2023-11-23 at 15 40 06

This PR reverts the change.

@tommartensen tommartensen self-assigned this Nov 23, 2023
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 23, 2023

A single node development cluster (infra-pr-1084) was allocated in production infra for this PR.

CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.8.7-15-g77ecf9333c to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1084 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen tommartensen deleted the tm/revert-namor branch November 23, 2023 13:29
@tommartensen tommartensen reopened this Nov 23, 2023
@tommartensen tommartensen requested a review from a team as a code owner November 23, 2023 14:50
@tommartensen tommartensen enabled auto-merge (squash) November 23, 2023 14:52
@tommartensen tommartensen requested a review from a team November 23, 2023 14:52
@vjwilson
Copy link
Contributor

@tommartensen
You don't have to revert this upgrade.
You could just update the option name that was deprecated to the new option.
https://github.com/jsonmaur/namor.js/blob/master/CHANGELOG.md#deprecations

Replace saltLength with salt

https://github.com/stackrox/infra/blob/master/ui/src/utils/cluster.utils.ts#L16-L17

@tommartensen
Copy link
Contributor Author

tommartensen commented Nov 28, 2023

@vjwilson thanks, unfortunately, the error does not go away, tested in #1085. Because master is currently broken, I would want to continue with the revert and open a new PR for the upgrade & fix.

Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tommartensen tommartensen merged commit 63efcf4 into master Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants