Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe from any child comment #652

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rleed
Copy link
Contributor

@rleed rleed commented Nov 22, 2023

Intended to close #512.

I'm opening this in draft because it's kicking my butt for such a simple function and I don't know how to get further with it. I'm getting hydration errors and not sure what's missing that's causing that. If anyone can bring it forward without much time/effort, help is welcome, otherwise I'm strategically "giving up" on it. Sorry about that. I hate making unwanted work for other people, so feel free to just close it if it's not priority enough right now.

@ekzyis
Copy link
Member

ekzyis commented Dec 4, 2023

I'm getting hydration errors and not sure what's missing that's causing that. If anyone can bring it forward without much time/effort, help is welcome, otherwise I'm strategically "giving up" on it.

Oh, didn't read this, never clicked on this PR because it was a draft, lol

Clicked on this now because I think being able to unsubscribe only gets more and more important and wanted to see what's up here since I just went through my mails and found the notification for this PR in there.

Sorry about that. I hate making unwanted work for other people, so feel free to just close it if it's not priority enough right now.

It's okay, as you said, we can just close it if we don't want to do the work :) It's not a priority right now and only big things have real "priorities". But I also like to look at the smaller stuff between bigger stuff. Small stuff can add up!

Not going to close until I have taken a look though. There is probably code that we will use and even code that doesn't work helps since we now know that doesn't work, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow unsubscribing from our own threads
2 participants