Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unsubscribing from our own threads #512

Closed
huumn opened this issue Sep 21, 2023 · 2 comments · May be fixed by #652
Closed

Allow unsubscribing from our own threads #512

huumn opened this issue Sep 21, 2023 · 2 comments · May be fixed by #652
Labels
feature new product features that weren't there before

Comments

@huumn
Copy link
Member

huumn commented Sep 21, 2023

Occasionally a thread will fork into a tangent and I want to tune it out.

MVP is probably just allowing us to unsubscribe from our own post/comment.

Ideally, we can unsubscribe from any child comment ... that way we can unsubscribe from just the tangent.

@huumn huumn added the feature new product features that weren't there before label Sep 21, 2023
@rleed
Copy link
Contributor

rleed commented Oct 17, 2023

Ideally, we can unsubscribe from any child comment ... that way we can unsubscribe from just the tangent.

I've given this some thought... I think a general solution would easily become prohibitively expensive. I think we need to restrict this feature for example by saying all unsubscriptions will take precedence (meaning you can't arbitrarily nest unsubscriptions and subscriptions). Your thoughts?

(EDIT: Let me clarify what I mean by unsubscriptions in this case: a record in the database indicating that a particular post has been positively unsubscribed, not just that it has no subscription. Probably indicated by a new flag in the existing ThreatSubscription table.)

@huumn
Copy link
Member Author

huumn commented Oct 19, 2023

a record in the database indicating that a particular post has been positively unsubscribed, not just that it has no subscription.

You're right! I had the same thought yesterday. It'll be so much easier to be able to assume all children threads are subscribed to and let stackers selectively unsubscribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new product features that weren't there before
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants