Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let secret-operator handle PKCS#12 conversion #598

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Let secret-operator handle PKCS#12 conversion #598

wants to merge 3 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jun 22, 2023

Description

Kafka version of stackabletech/zookeeper-operator#695. Requires stackabletech/secret-operator#286, stackabletech/operator-rs#610, and stackabletech/product-config#88.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

nightkr
nightkr commented Jun 22, 2023
View reviewed changes
rust/crd/src/security.rs
Comment on lines -201 to -206
// Copy system truststore to stackable truststore
args.push(format!("keytool -importkeystore -srckeystore {system_trust_store_dir} -srcstoretype jks -srcstorepass {ssl_store_password} -destkeystore {stackable_tls_server_dir}/truststore.p12 -deststoretype pkcs12 -deststorepass {ssl_store_password} -noprompt",
system_trust_store_dir = Self::SYSTEM_TRUST_STORE_DIR,
ssl_store_password = Self::SSL_STORE_PASSWORD,
stackable_tls_server_dir = Self::STACKABLE_TLS_SERVER_DIR,
));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked about this on Slack (https://stackable-workspace.slack.com/archives/C0312UB3LLE/p1687429824406039). Still not sure about whether this is something we support intentionally or not...

@nightkr nightkr requested a review from a team June 22, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nightkr