Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/csi dependency upload script #668

Merged
merged 8 commits into from
May 24, 2024

Conversation

Maleware
Copy link
Contributor

Description

This adds a upload script for csi-provisioner and csi-node-driver-registrar. It's not sophisticated and a more or less quick and dirty approach.

Signing is not perfect as of now since it would needed to be from a gh action to count as valid therefore I will leave the step within the script but comment it out for now.

It doesn't need to be merged but I wanna leave the script somewhere visible.

May the audience judge about the merge.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Edit tasklist title
Beta Give feedback Tasklist Tasks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. All added packages (via microdnf or otherwise) have a comment on why they are added
    Options
  3. Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
    Options
  4. All packages should have (if available) signatures/hashes verified
    Options
  5. Does your change affect an SBOM? Make sure to update all SBOMs
    Options
  6. Add an entry to the CHANGELOG.md file
    Options
  7. Integration tests ran successfully
    Options
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

upload_sig_storage_driver.sh Show resolved Hide resolved
upload_sig_storage_driver.sh Outdated Show resolved Hide resolved
upload_sig_storage_driver.sh Outdated Show resolved Hide resolved
upload_sig_storage_driver.sh Show resolved Hide resolved
upload_sig_storage_driver.sh Outdated Show resolved Hide resolved
upload_sig_storage_driver.sh Outdated Show resolved Hide resolved
@Maleware Maleware added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 98f2b7d May 24, 2024
13 checks passed
@Maleware Maleware deleted the feature/csi-dependency-upload-script branch May 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants