Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Links Behaviour #18

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed Links Behaviour #18

wants to merge 3 commits into from

Conversation

sandipkarmokar
Copy link

Changed made:

Fixed links behaviour from where they opened in the same window to an external window (It was bad UX, since we were pointing to external links, they should have opened in external window)
In the footnote (Apache 2.0 License © Resume Matcher Contributors), the color blue-600 wasnt being rendered, changed it to blue-200 to match the other colors of the footer

@sandipkarmokar
Changes made:
c8b8c97 
fixed links, now they open in an external window
The footnote had text-blue-600, it was not being reflected in the website, changed it to blue-200 to make the color of the other links
@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-for-resume-matcher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 1:59pm

@millette millette mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sandipkarmokar