Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Alt tags to images and added meta description to index.html #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nel417
Copy link

@nel417 nel417 commented Jun 27, 2020

The accessibility was dangerously low for the site (36 via lighthouse) and thought alt tags would be a good start for the overall accessibility and SEO.

Added meta description for SEO, it was scoring fairly low as well (78 via lighthouse)

If alt tags should be the images description over hover instead of the name of the repo, I would be more than happy to change them.

Added meta description, SEO is scoring a 78 via Lighthouse. Alt tags will help the accessibility and SEO for the square open source portal.
Added alt tags to images, Accessibility is scoring dangerously low at 36 and feel like alt tags would be a good start for accessibility and SEO, if you feel the repo descriptions (that display when the image is hovered over) would be a better fit instead of the logo(repo) name, I would be more than happy to swap them out.
Copy link
Contributor

@zach-klippenstein zach-klippenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thanks! Unfortunately the file you modified, index.html is generated (see the README). To make this actually stick past the next generation, you'll need to edit the moustache template instead, and then run the script to regenerate the HTML.

@nel417
Copy link
Author

nel417 commented Jun 27, 2020

sounds good, I'll hop on the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants