feat/adding scalar-variable expression #1260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8973785216Details
💛 - Coveralls |
8 tasks
iffyio
reviewed
May 9, 2024
| @@ -793,6 +793,11 @@ pub enum Expr { | |||
| OuterJoin(Box<Expr>), | |||
| /// A reference to the prior level in a CONNECT BY clause. | |||
| Prior(Box<Expr>), | |||
| /// Scalar variable creation e.g. `[@]foo INT` | |||
There was a problem hiding this comment.
Would it be possible to add a link to some documentation that uses this expression? I think that would be helpful in this case - e.g I'm unfamiliar with the syntax and unable to tell how it's used as a result
| @@ -793,6 +793,11 @@ pub enum Expr { | |||
| OuterJoin(Box<Expr>), | |||
| /// A reference to the prior level in a CONNECT BY clause. | |||
| Prior(Box<Expr>), | |||
| /// Scalar variable creation e.g. `[@]foo INT` | |||
| ScalarVariable { | |||
There was a problem hiding this comment.
hmm, it looks like we're missing implementation in the PR for how the parser actually parses/constructs the ScalarVariable expression or is that intended?
|
@iffyio it is likely that this PR will not be needed, there is another route I am taking with the Scalar Variable in datafusion 👍 will leave it up just in case though. |
|
marking as draft as we sort out what to do here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalarVariableexpression typeScalarVariablehas two fields one for the corresponding SQL datatype and one of the name of the variableExpr --> Stringapache/datafusion#9726