Add full support for on conflict clause in SQLite #5888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
upsert
clause support withon conflict
to the sqlite dialect, as described here. 7ee8d7don conflict
to the sqlite dialect clause as described here closing Unable to parse sqliteon conflict
clause #3872 2314d7balter table
clauses not working in sqlite closing SQLite statements with ALTER TABLE are not parsed #5732 ef751ddAre there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.
I'm not 100% clear on how you guys structure merges into main, I decided to just make a single branch with all my commits as it was easier for me, if you prefer I can split it back up as the commits are pretty clearly separate with the caveat that 2314d7b depends on ef751dd which is why I structured it this way.