Fix Athena Partitioned By format for iceberg tables

[jverhoeks]

Brief summary of the change made

fixes #5398

The parser for create table expects a ColumnDefinitionSegment at the PARTITIONED BY statement. This is expecting , but according the documentation: https://docs.aws.amazon.com/athena/latest/ug/querying-iceberg-creating-tables.html. This should be just

Example:

CREATE TABLE iceberg_table (id bigint, data string, category string) 
PARTITIONED BY (category)) LOCATION 's3://DOC-EXAMPLE-BUCKET/your-folder/' 
TBLPROPERTIES ( 'table_type' = 'ICEBERG' )

Updated the parser to NakedIdentifierSegment to accept the fieldname without quotes

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

• Please confirm you have completed any of the necessary steps below.

• Included test cases to demonstrate any code changes, which may be one or more of the following:

  • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).

• Added appropriate documentation for the change.

• Created GitHub issues for any relevant followup/future enhancements if appropriate.

[WittierDinosaur]

LGTM

[WittierDinosaur]

You need to generate the new test yml, please run python3 test/generate_parse_fixture_yml.py --dialect=athena

[jverhoeks]

The fix seems to be more complicated. For external tables the partioned by does require a while for the create table not. I'll work on an updated pr.

[WittierDinosaur]

Incase it makes this easier, our general philosophy is - make it parse all valid SQL. We're less concerned about invalid combinations successfully parsing