Create local Docker dev environment #4694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4646744947
💛 - Coveralls |
barrywhart
reviewed
Apr 8, 2023
| fresh: | ||
| docker-compose build --no-cache development | ||
|
|
||
| run: |
There was a problem hiding this comment.
Does run need to depend on create?
| To build a simple interactive Docker container, run the following commands: | ||
| ```shell | ||
| make create | ||
| make run |
There was a problem hiding this comment.
How would I shell into the container if I want to run commands directly there? Would it be worth adding a make target for that?
Have you run the sqlfluff-templater-dbt tests in the container to verify they work?
| docker-compose build --no-cache development | ||
|
|
||
| run: | ||
| docker-compose run --rm development |
There was a problem hiding this comment.
It looks like this runs the container synchronously. Is there a way to run it in the background (i.e. the -d option)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Adds a local Docker environment for easier developing.
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.