Add setter method for userDetailsChecker in CasAuthenticationProvider(#10277) #15047
Conversation
|
@Kyoungwoong Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@Kyoungwoong Thank you for signing the Contributor License Agreement! |
| * | ||
| * @param userDetailsChecker the UserDetailsChecker to be set | ||
| */ | ||
| public void setUserDetailsChecker(UserDetailsChecker userDetailsChecker) { |
There was a problem hiding this comment.
| public void setUserDetailsChecker(UserDetailsChecker userDetailsChecker) { | |
| public void setUserDetailsChecker(final UserDetailsChecker userDetailsChecker) { |
marcusdacoregio
added
in: cas
There was a problem hiding this comment.
Thanks for the PR @Kyoungwoong, I've left some feedback inline.
Can you please add a test that makes sure that when setting the UserDetailsChecker it is used where needed?
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2004, 2005, 2006 Acegi Technology Pty Limited | |||
| * Copyright 2004, 2005, 2006, 2024 Acegi Technology Pty Limited | |||
There was a problem hiding this comment.
We don't typically change copyright notices from Acegi, you can leave it as it was.
| * Copyright 2004, 2005, 2006, 2024 Acegi Technology Pty Limited | |
| * Copyright 2004, 2005, 2006 Acegi Technology Pty Limited |
| * @param userDetailsChecker the UserDetailsChecker to be set | ||
| */ | ||
| public void setUserDetailsChecker(final UserDetailsChecker userDetailsChecker) { | ||
| this.userDetailsChecker = userDetailsChecker; |
There was a problem hiding this comment.
Can you please verify that the userDetailsChecker is not null?
| this.userDetailsChecker = userDetailsChecker; | |
| Assert.notNull(userDetailsChecker, "userDetailsChecker cannot be null"); | |
| this.userDetailsChecker = userDetailsChecker; |
| * Sets the UserDetailsChecker to be used for checking the status of retrieved user details. | ||
| * This allows customization of the UserDetailsChecker implementation. | ||
| * | ||
| * @param userDetailsChecker the UserDetailsChecker to be set |
There was a problem hiding this comment.
Please add @since 6.4
…pring-projects#10277) This commit introduces a setter method for the userDetailsChecker property in the CasAuthenticationProvider class. Previously, the userDetailsChecker was initialized with a default AccountStatusUserDetailsChecker instance, limiting customization options. Now, users can inject their own UserDetailsChecker implementation through the setter method, providing greater flexibility in handling user details validation.
|
All review has been resolved. |
|
Thanks @Kyoungwoong. This is now merged into |
This commit introduces a setter method for the userDetailsChecker property in the CasAuthenticationProvider class. Previously, the userDetailsChecker was initialized with a default AccountStatusUserDetailsChecker instance, limiting customization options. Now, users can inject their own UserDetailsChecker implementation through the setter method, providing greater flexibility in handling user details validation.
fixes: #10277