Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:when invoke ZhiPuAiEmbeddingModel.call method request body format error #763

Closed
wants to merge 5 commits into from

Conversation

wb04307201
Copy link
Contributor

@wb04307201 wb04307201 commented May 24, 2024

when invoke ZhiPuAiEmbeddingModel.call method, I get some error,like this
image

then check ZhiPuAiEmbeddingModel class and ZhiPuAi website
image
image
in ZhiPuAiEmbeddingModel class use a Collection, but in website input is String

so I transform List to String, then everything is right!

@mxsl-gr
Copy link
Contributor

mxsl-gr commented May 26, 2024

Hi, thanks for reporting and PR.

I have reproduced the bug, the unit tests do not cover multiple text embeddings.

but simply concatenating texts does not meet the API's intent, as passing in multiple text embeddings should return multiple embedding vectors, not a single merged one.

I think we can create a new issue. what do you think?

@wb04307201
Copy link
Contributor Author

wb04307201 commented May 26, 2024

OK, I will create a new issue.

@wb04307201 wb04307201 closed this by deleting the head repository May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants