Add JSON type detection to handle both arrays and objects #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Type checking for JSON root node using JsonNode - Utilize Stream API to process JSON arrays - Modify parsing logic to handle both JSON arrays and objects
rivkode
changed the title
rivkode
changed the title
- Use stream to process jsonKeysToUse
injae-kim
reviewed
May 23, 2024
| @@ -58,41 +62,37 @@ public JsonReader(Resource resource, JsonMetadataGenerator jsonMetadataGenerator | |||
|
|
|||
| @Override | |||
| public List<Document> get() { | |||
| ObjectMapper objectMapper = new ObjectMapper(); | |||
| List<Document> documents = new ArrayList<>(); | |||
| try { | |||
| // TODO, not all json will be an array | |||
- max depth: 4 - array length: 2 - number of root elements: 6
rivkode
commented
May 24, 2024
Comment on lines
48
to
+51
| @Test | ||
| void loadJson() { | ||
| assertThat(resource).isNotNull(); | ||
| JsonReader jsonReader = new JsonReader(resource, "description"); | ||
| void loadJsonObject() { | ||
| assertThat(ObjectResource).isNotNull(); | ||
| JsonReader jsonReader = new JsonReader(ObjectResource, "description"); |
|
Thanks for the contribution, will review after we release M1, moving this to M2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am considering the following for future improvements as below.
issue link