Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Typesense vector store adapter #728

Closed

Conversation

PabloSanchi
Copy link
Contributor

This PR adds support for Typesense vector store to Spring AI.
More details about Typesense can be found here.

PabloSanchi and others added 30 commits April 6, 2024 19:06
@tzolov
Copy link
Collaborator

tzolov commented May 19, 2024

Hey @PabloSanchi , thank you for the contribution.
Have not used the Typesense but like the fact it is open sourced and can be tested in docker containers.
Regarding the later could you please add IT tests for the Typesense auto-configuration.
Also rename the spring-ai-typesense module and pom artifact to spring-ai-typesense-store instead.
and the boot-starter module spring-ai-starter-typesense to spring-ai-starter-typesense-store and the artifact from spring-ai-typesense-spring-boot-starter to spring-ai-typesense-store-spring-boot-starter

@PabloSanchi
Copy link
Contributor Author

Now it should be fixed, I added the tests and renamed the class, I can see that there are conflicts though

@PabloSanchi
Copy link
Contributor Author

I will fix it as soon as I can :)

@markpollack markpollack added this to the 1.0.0-M2 milestone May 24, 2024
@tzolov
Copy link
Collaborator

tzolov commented Jun 15, 2024

Thank you again @PabloSanchi ! Good stuff.
I made few small adjustments and it is ready to merge.

@tzolov
Copy link
Collaborator

tzolov commented Jun 15, 2024

Rebased, squashed and merged at 3e2ed8b

@tzolov tzolov closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants