Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Avoid cycle in getScheme(). #3983

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OlgaMaciaszek
Copy link
Collaborator

Changes necessary after merging: spring-cloud/spring-cloud-commons#937.
Only merge after the commons PR is merged.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #3983 (993f4ee) into master (9804818) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3983      +/-   ##
============================================
+ Coverage     55.11%   55.15%   +0.03%     
- Complexity      507      508       +1     
============================================
  Files            57       57              
  Lines          2464     2466       +2     
  Branches        228      228              
============================================
+ Hits           1358     1360       +2     
+ Misses         1019     1018       -1     
- Partials         87       88       +1     
Impacted Files Coverage Δ Complexity Δ
...rk/cloud/netflix/eureka/EurekaServiceInstance.java 48.00% <66.66%> (+0.17%) 8.00 <1.00> (ø)
.../netflix/eureka/server/EurekaServerConfigBean.java 22.73% <0.00%> (+0.23%) 32.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9804818...993f4ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant