-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ improvements #63
base: main
Are you sure you want to change the base?
C++ improvements #63
Conversation
2627b00
to
7514561
Compare
af175e7
to
591c6fe
Compare
591c6fe
to
4f3309c
Compare
6ead919
to
406b4e0
Compare
@@ -0,0 +1 @@ | |||
cpp/.clang-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
softlink to allow the clang-format github action to work correctly
51bf712
to
be468a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but if we're adding C++ tests (even just the one) in this PR, IMO we should add them to the GitHub Actions workflow so they run on CI before merging this.
mvn package | ||
``` | ||
|
||
this will update the java documentation located in [docs/java/](https://github.com/spotify/voyager/tree/main/docs/java). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will update the java documentation located in [docs/java/](https://github.com/spotify/voyager/tree/main/docs/java). | |
This will update the java documentation located in [docs/java/](https://github.com/spotify/voyager/tree/main/docs/java). |
without any pressure - is there a timeframe for merging this? just asking for our own planning on when to start integrating these changes |
just a friendly ping - any update on this? do you think it makes sense for potential users to start picking up your branch directly instead of waiting for this to be merged? @markkohdev |
Description
In this PR we will:
Changes Made
C++
Main changes:
cpp
dir intosrc
andtest
directoriesPython
voyager-headers
link since it doesn't seem to be neededJava
Testing
Checklist
Additional Comments