trampoline: use exponential search for fees, capped by configurable budget #9041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values for exponential search are based on available fee budget: we try with budget/64, budget/32, ..., budget/1 (spread uniformly among the selected Trampoline Forwarders). Hence, if we make the fee budget configurable, that will usefully affect the trampoline fees as well. related spesmilo#9033
SomberNight
force-pushed
the
202405_tramp1
branch
2 times, most recently
from
f6ddc44
to
bc4e6fc
Compare
SomberNight
commented
May 8, 2024
Comment on lines
+158
to
+161
| MAX_LEVEL = 6 | ||
| if trampoline_fee_level > MAX_LEVEL: | ||
| raise NoPathFound() | ||
| budget_to_use = budget.fee_msat // (2 ** (MAX_LEVEL - trampoline_fee_level)) |
There was a problem hiding this comment.
Note: this logic means that the lowest total fee we will try is the user configured max divided by 32. E.g. by default the max is 1% of payment amount, i.e. fee=1/3200*payment_amount.
If the user configures a higher max budget, that raises the corresponding the lowest possible fee we will try.
- make PaymentFeeBudget proportional fee and flat cutoff fee configurable - closes spesmilo#7622 - increase flat cutoff fee default to 10 sat - closes spesmilo#7669 - rm RouteEdge.is_sane_to_use() (per edge limit) and just rely on budgets (per route limit)
Expose as a slider; perhaps it is less footgunny this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.
closes #9033