Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: since we have jsonpatch, save labels immediately upon setting. #8736

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

accumulator
Copy link
Member

No description provided.

@accumulator accumulator marked this pull request as ready for review December 11, 2023 12:46
@ecdsa
Copy link
Member

ecdsa commented Dec 11, 2023

jsonpatch is only enabled on non-encrypted wallets

@accumulator
Copy link
Member Author

jsonpatch is only enabled on non-encrypted wallets

hmm, yes, that is unfortunate.

@ecdsa
Copy link
Member

ecdsa commented Dec 12, 2023

in order to enable this with encrypted wallets, we need to define proper file header.
see the last commits of master...jsonpatch

@accumulator accumulator added this to the backlog milestone Dec 12, 2023
@accumulator accumulator marked this pull request as draft December 18, 2023 13:51
@SomberNight
Copy link
Member

more context from irc:
<accumulator> on android you can 'hard' close the app, bypassing the save wallet on close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants