Allow not using symlinks when fetching files #2476
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently this is just mocking up APIs and writing proofs-of-concept.
The goal of this PR would ultimately be to explore ways to avoid using symbolic links in most cases in SB (which should e.g. definitely not be done when using
load_audio
against local paths in inference APIs...)As of the current state of the PR:
fetch
is extended to accept alocal_strategy
parameter. This parameter controls the behavior for downloading and copying/linking files around.fetch
now accepts and forwards the same parameter.SYMLINK
toNO_LINK
on all platforms (can be debated).NO_LINK
by default since polluting the working directory with audio files is largely undesired.NO_LINK
behavior.Resolves #1070, resolves #1278, resolves #2197, resolves #1885, resolves #1155, resolves #1586
Supersedes #1303
Before submitting
PR review
Reviewer checklist