Feat/barchart updates #1388
Open
Feat/barchart updates #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
patriksvensson
requested changes
Nov 28, 2023
There was a problem hiding this comment.
We need to cover the new functionality with some tests and update the documentation for the BarChart. I also think that the Progress bar changes should be moved to its own PR.
Also, we will need you to fill out the PR template as part of the PR. You can find it here: https://raw.githubusercontent.com/spectreconsole/spectre.console/main/.github/pull_request_template.md
6 tasks
patriksvensson
requested changes
Dec 26, 2023
|
We will also need to update the documentation so it reflect the new additions. |
patriksvensson
requested changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to start the process for this PR to make it add more clarity on the issue #1382 raised to see exactly what was changed and to start the conversation
Key points
Added
ValueFormatterfor bar chart based on breakdown chartAdded label color option
I have read the Contribution Guidelines
I have commented on the issue above and discussed the intended changes
A maintainer has signed off on the changes and the issue was assigned to me
All newly added code is adequately covered by tests
All existing tests are still running without errors
The documentation was modified to reflect the changes OR no documentation changes are required.
Please upvote 👍 this pull request if you are interested in it.