IndexOf replaced by Count at Add method - Performance issue #975 fixed #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When printing tens of thousands of lines, there is a performance issue. The TableRowCollection -> Add method was being called millions of times. Once it is called, it returns the index of the added element. As the element is added to a List (new List<TableRow>, I believe it is not needed to use IndexOf because it will be added always at the last position. Replacing the IndexOf call by a Count - 1 improves the performance in this scenario. Related issue: spectreconsole#975
|
|
maije
changed the title
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to calculate the index of a new object in the collection if the position is always the (Count-1) after the addition.
The Add method at TableRowCollection is being called billions (US) of times for tens of thousands of prints.
Comparative metrics regarding this issue can be found at #975