recreate BackedEnums when applying Manipulations

[tkempf]

Fixes Issue #3582

[Nielsvanpach]

Could you add a test case to make sure this fix solves the problem?

[Nielsvanpach]

Could you use a match operator instead?

[tkempf]

What do you think about using neither match nor switch. Just recreate all Enums if the parameter is present independent of thy type of manipulation

Suggested change

	switch($manipulationName){
	(isset($parameters['type'])) && $parameters['type'] = BorderType::from($parameters['type']) ;
	(isset($parameters['fit'])) && $parameters['fit'] = Fit::from($parameters['fit']);
	(isset($parameters['position'])) && $parameters['position'] = AlignPosition::from($parameters['position']);
	(isset($parameters['colorFormat'])) && $parameters['colorFormat'] = ColorFormat::from($parameters['colorFormat']);
	(isset($parameters['constraints'])) && $parameters['constraints'] = Constraint::from($parameters['constraints']);
	(isset($parameters['position'])) && $parameters['position'] = CropPosition::from($parameters['position']);
	(isset($parameters['fit'])) && $parameters['fit'] = Fit::from($parameters['fit']);
	(isset($parameters['flip'])) && $parameters['flip'] = FlipDirection::from($parameters['flip']);

[freekmurze]

I think a match we be more clear in this case

[Nielsvanpach]

Suggested change

	(isset($parameters['type'])) && $parameters['type'] = BorderType::from($parameters['type']) ;
	(isset($parameters['type'])) && $parameters['type'] = BorderType::from($parameters['type']);

[MrMeshok]

There is also valid usage without named parameters

$media->manipulations = [
    'default' => [
        'border' => [
            1,
            BorderType::Expand,
            '000000'
        ]
    ]
];

I see 2 solutions there:

1. Try to find enum from parameters array by named parameter key or numeric position e.g. BorderType::from($parameters['type'] ?? $parameters[1])
2. Use reflection and check ImageDriver method parameters before calling it

Obviously reflection would be better, but there performance concerns, so it needs benchmarking.

I could take over this issue as this also need for my use case

[timvandijck]

@tkempf thank you for your work!

@MrMeshok I'm going to already merge this PR, but if you have some more improvements on this topic I would be happy to look at a new PR from you.