Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch: build with external gloo #40759

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

adamjstewart
Copy link
Member

Trying to get PyTorch to build entirely with Spack-installed deps.

@spackbot-app
Copy link

spackbot-app bot commented Oct 28, 2023

Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

  • gloo

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("adamjstewart")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame gloo

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@adamjstewart
Copy link
Member Author

Builds fine for PyTorch 2.1 but not for 2.0, and horovod does not yet support 2.1 so we can't avoid building 2.0 in CI without dropping horovod. @tgaddair @thomas-bouvier any thoughts on how long it will take to fix horovod/horovod#3996?

alalazo
alalazo previously approved these changes Oct 30, 2023
@alalazo
Copy link
Member

alalazo commented Oct 30, 2023

@adamjstewart Feel free to merge (not sure if you're waiting for further reviews on this PR).

@thomas-bouvier
Copy link
Contributor

@adamjstewart I was waiting for #40057 to be merged, working on it!

@adamjstewart adamjstewart merged commit 58e5315 into spack:develop Oct 31, 2023
13 checks passed
@adamjstewart adamjstewart deleted the packages/gloo branch October 31, 2023 21:25
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2023
* PyTorch: build with external gloo

* Fix gloo compilation with GCC 11

* undeprecate

* py-torch+cuda+gloo requires gloo+cuda
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
* PyTorch: build with external gloo

* Fix gloo compilation with GCC 11

* undeprecate

* py-torch+cuda+gloo requires gloo+cuda
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
* PyTorch: build with external gloo

* Fix gloo compilation with GCC 11

* undeprecate

* py-torch+cuda+gloo requires gloo+cuda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants