Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual P2P Discovery #2380

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

oscartbeaumont
Copy link
Member

@oscartbeaumont oscartbeaumont commented Apr 24, 2024

https://discord.com/channels/949090953497567312/1230767171874062389/1232607428584013854

  • Implement settings UI for it
  • Force a P2P port with Docker through an environment variable
  • Expose the port from the container
  • Make the NodeConfigP2P::manual_peers work.

Remaining issues:

  • tokio::net::lookup_host doesn't like FQDN's
  • Track tokio::net::lookup_host errors so we can show them on the frontend
  • Peer is connectable but not showing up in P2P state

@oscartbeaumont oscartbeaumont requested a review from a team as a code owner April 24, 2024 08:29
Copy link

linear bot commented Apr 24, 2024

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 5:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 5:28am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant