[ENG-1184, ENG-1286, ENG-1330] Rework native dependencies (+ deb fixes) #1685
+547
−3,377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FFMpeg 6.0 uses some now removed deprecated functions
ENG-1330 Vendor FFmpeg for Linux
Create a FFmpeg build script for linux to compile our own version of ffmpeg, so we don't depend on the system version for the deb and appimage releases |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HeavenVolkoff
changed the title
ENG-1184 Rework windows ffmpeg script to use zig
Zig offers a self-contained C/C++ cross compiler setup that is much easier to use than the current setup we are using for compiling ffmpeg for windows. Besides making easier to maintain the current building scripts, it also has out of the box support for windows arm64, which would remove one of the blockers to support this platform in Spacedrive |
HeavenVolkoff
force-pushed
the
eng-1330-1184-rework-ffmpeg
branch
from
8e603fc
to
20bfaa6
Compare
This was referenced Oct 27, 2023
- Update zig for windows target
…essing - Disable opengl and directx for libplacebo, ffmpeg only supports vulkan when using it - Add WIN32_LEAN_AND_MEAN to global cflags to optimize windows api usage - Fix 99-heif.sh incorrect bsdtar flag
…enCL build - Fix Dockerfile step for cleaning up the out dir - Improve licensing handling
HeavenVolkoff
force-pushed
the
eng-1330-1184-rework-ffmpeg
branch
from
5cbadd2
to
8f8682a
Compare
- Fix soxr failing to download due to sourcefourge - Only patch zimg on windows targets - Tell cmake to hide libheif symbols
- Add lzo dependency - Publish source for the built libs - Add warning for missing nasm in tauri.mjs - Remove ffmpeg install from setup.sh - Add download logic for our linux ffmpeg bundle in preprep.mjs
- Rename FFMpeg.framework to Spacedrive.framework - Centralize the macOS native deps build with the windows and linux one - Change the preprep script to only download our native deps - Remove old macOS ffmpeg build scripts
fogodev
previously approved these changes
Nov 15, 2023
HeavenVolkoff
force-pushed
the
eng-1330-1184-rework-ffmpeg
branch
from
bee5c08
to
6bb7915
Compare
HeavenVolkoff
force-pushed
the
eng-1330-1184-rework-ffmpeg
branch
from
53ea7d4
to
eaea5f1
Compare
HeavenVolkoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework Spacedrive's native dependency build system to be a unified set of scripts that download/prepare/build/package all the required runtime native dependencies (ffmpeg libs, libheif, libpdfium) to run Spacedrive on all of its supported OSes.
Remove the old separate set of FFMpeg/libheif build scripts for macOS/Windows/Linux from the main repository
Create a new repository for the new build system: https://github.com/spacedriveapp/native-deps. This has the advantage of decoupling the native-deps from Spacedrive's release cycle, and also allows us to use releases instead of CI artifacts for distribution, which free us from the limits GitHub places on distributing artifacts (3 months expire limit, no public URL, requires using GitHub's API)
Rework preprep.mjs script to download and set up our new unified native-deps bundle for dev. Remove code for dealing with GitHub API, now that we use releases, that code is not needed anymore.
Rename macOS FFMpeg.framework to Spacedrive.framework
Remove ffmpeg libs install step from setup.sh
Change minimum supported macOS on arm to 11.0 (from 11.2)
Fix deb release issues raised by Lintian
This PR was tested on: