[ENG-1690] Upgrade to Tauri 2.0 #8897
ci.yml
on: pull_request
TypeScript
1m 37s
ESLint
2m 23s
Cypress
18m 7s
Rust Formatting
24s
Matrix: clippy
Annotations
22 warnings
ESLint:
interface/app/$libraryId/Explorer/View/MediaView/index.tsx#L165
React Hook useMemo has a missing dependency: 'dateFormat'. Either include it or remove the dependency array
|
ESLint:
interface/app/$libraryId/Explorer/View/ViewItem.tsx#L194
React Hook useCallback has a missing dependency: 't'. Either include it or remove the dependency array
|
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method:
crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method
--> crates/sync/src/compressed.rs:90:2
|
90 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L794
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:794:10
|
794 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
note: the lint level is defined here
--> core/crates/heavy-lifting/src/lib.rs:9:2
|
9 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L1086
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:1086:10
|
1086 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead:
core/src/location/indexer/old_walk.rs#L499
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead
--> core/src/location/indexer/old_walk.rs:499:41
|
499 | let Ok(rules_per_kind) = IndexerRule::apply_all(indexer_rules, ¤t_path)
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead:
core/src/location/non_indexed.rs#L147
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead
--> core/src/location/non_indexed.rs:147:23
|
147 | match IndexerRule::apply_all(&rules, &entry_path).await {
| ^^^^^^^^^
|
used `unwrap()` on a `Result` value:
core/src/api/ephemeral_files.rs#L168
warning: used `unwrap()` on a `Result` value
--> core/src/api/ephemeral_files.rs:168:10
|
168 | ... trash::delete(&path).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
--> core/src/lib.rs:1:9
|
1 | #![warn(clippy::unwrap_used, clippy::panic)]
| ^^^^^^^^^^^^^^^^^^^
|
unused import: `PathBuf`:
apps/desktop/crates/linux/src/app_info.rs#L1
warning: unused import: `PathBuf`
--> apps/desktop/crates/linux/src/app_info.rs:1:23
|
1 | use std::path::{Path, PathBuf};
| ^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
function `remove_prefix_from_env_in_ctx` is never used:
apps/desktop/crates/linux/src/app_info.rs#L18
warning: function `remove_prefix_from_env_in_ctx` is never used
--> apps/desktop/crates/linux/src/app_info.rs:18:4
|
18 | fn remove_prefix_from_env_in_ctx(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `version` is never used:
apps/desktop/crates/linux/src/env.rs#L11
warning: function `version` is never used
--> apps/desktop/crates/linux/src/env.rs:11:4
|
11 | fn version(version_str: &str) -> i32 {
| ^^^^^^^
|
function `remove_prefix_from_pathlist` is never used:
apps/desktop/crates/linux/src/env.rs#L196
warning: function `remove_prefix_from_pathlist` is never used
--> apps/desktop/crates/linux/src/env.rs:196:15
|
196 | pub(crate) fn remove_prefix_from_pathlist(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
returning the result of a `let` binding from a block:
apps/desktop/crates/linux/src/app_info.rs#L40
warning: returning the result of a `let` binding from a block
--> apps/desktop/crates/linux/src/app_info.rs:40:3
|
39 | let ctx = AppLaunchContext::default();
| -------------------------------------- unnecessary `let` binding
40 | ctx
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
39 ~
40 ~ AppLaunchContext::default()
|
|
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method:
crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method
--> crates/sync/src/compressed.rs:90:2
|
90 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
cypress-videos
|
2.07 MB |
|