feat(projects): close tab by mouse wheel button click #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honghuangdc
reviewed
Mar 27, 2024
| function handleMouseup(e: MouseEvent) { | ||
| // close tab by mouse wheel button click | ||
| if (e.button === 1) { | ||
| emit('close'); |
There was a problem hiding this comment.
use handleClose replace emit('close')
JianJroh
force-pushed
the
feat/click-mousewheel-close-tab
branch
from
a03047e
to
ff74838
Compare
|
然后这个PR可以放到 下个版本中发布，先不着急 |
可以放到 v 1.1 版本中 #364 |
JianJroh
force-pushed
the
feat/click-mousewheel-close-tab
branch
from
ff74838
to
891d060
Compare
JianJroh
changed the title
|
重新 fork最新代码，然后在 v1.1.0 分支上创建新分支，提交代码后合并到 v1.1.0 上。通过 git cherry-pick 将这次提交复制过去 |
JianJroh
force-pushed
the
feat/click-mousewheel-close-tab
branch
from
891d060
to
d3849ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.